-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Buchwald2024 #1159
Buchwald2024 #1159
Conversation
@spaam-bot please autofill ancientmetagenome-environmental Buchwald2024 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Darcy220606,
Thanks for contributing this publication. All looks good so far. I only updated the strand type of the libraries because the authors cite to single-stranded DNA papers for their library building.
Out of curiosity, how did you infer the sample and library names? I couldn't find a proper table of these in the manuscript and could only stitch them together from ENA.
Thanks @alexhbnr for the review. Indeed, I also inferred the samples and libraries names from the names of the submitted ftps from the ENA table. |
As @alexhbnr is busy atm in Croatia, I will finish the review! |
AMDirT, version 1.5.0 SamplesAncient Metagenome Host Associated
Ancient Single Genome Host Associated
Ancient Metagenome Environmental
LibrariesAncient Metagenome Host Associated
Ancient Single Genome Host Associated
Ancient Metagenome Environmental
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made refines me to sampel metadata, library metadata looks good after Alex's change.
I find it weird the library IDs are shorter than the samples... but I guess they are unique enough here that it works.
Thank's @Darcy220606 !
Pull Request
This PR is for a
For the following list(s):
This is to close #1140
PR Workflow
@spaam-bot please autofill <table_name> <project_id>
to get a half-filled template! (may take a minute or so to get the comment with the file)Pre-review checklist (new publications)
@spaam-bot please autofill <table_name> <project_id>
to get a half-filled template! May take a minute or so to get the comment with the file