Fix Cycles::EndOf #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
V1E18MF{some_date} means "add 17 months and go to the last day of that month"
We had been calculating "add 18 months and go to the last day of that month"
EndOf#expiration_of(...) always returns #final_date
jdowd
force-pushed
the
fix/end-of-expires-after
branch
from
7d15ffc to
f5e1fb6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The behavior was wrong.
Whereas other cycles determine accomplishment by examining whether the
completed_datesinclude a sufficient quantity fall in-window values, aCycles::EndOfis by definition satisfied until its#final_date