From 97314ccfe51fd66e33821dd6fce63c44939842eb Mon Sep 17 00:00:00 2001 From: Ruairidh MacLeod Date: Mon, 9 Aug 2021 16:29:02 +0100 Subject: [PATCH] Release v4.0.0 (#883) * generate changelog for release * update regex in releasing docs * bump versions for release --- CHANGELOG.md | 52 ++++++++++++++++++++++++++++++++++++++- README.md | 2 +- docs/RELEASING.md | 2 +- news/764-bugfix.md | 1 - news/841-bugfix.md | 1 - news/843-meta.md | 1 - news/844-meta.md | 1 - news/848-removal.md | 1 - news/849-feature.md | 5 ---- news/855-meta.md | 1 - news/859-meta.md | 1 - news/861-feature.md | 1 - news/876-meta.md | 1 - news/877-meta.md | 1 - news/878-feature.md | 1 - news/880-bugfix.md | 1 - src/SharedAssemblyInfo.cs | 6 ++--- 17 files changed, 56 insertions(+), 23 deletions(-) delete mode 100644 news/764-bugfix.md delete mode 100644 news/841-bugfix.md delete mode 100644 news/843-meta.md delete mode 100644 news/844-meta.md delete mode 100644 news/848-removal.md delete mode 100644 news/849-feature.md delete mode 100644 news/855-meta.md delete mode 100644 news/859-meta.md delete mode 100644 news/861-feature.md delete mode 100644 news/876-meta.md delete mode 100644 news/877-meta.md delete mode 100644 news/878-feature.md delete mode 100644 news/880-bugfix.md diff --git a/CHANGELOG.md b/CHANGELOG.md index 457bf48f2..584cfe233 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -11,6 +11,55 @@ A raw git diff can be seen [here][unreleased]. +## [4.0.0] 2021-08-09 + +## Feature + +- [#849](https://github.com/SMI/SmiServices/pull/849) by jas88. CTPAnonymiser + refactoring + - Reduce memory footprint (issue #837) + - Simplify RabbitMQ message handling + - Stop creating temporary copy of input file - no longer needed in EPCC + environment without Lustre FS (per issue #836) + - Add checks input file is readable not just extant, hopefully fixing + issue #533 +- [#861](https://github.com/SMI/SmiServices/pull/861) by rkm. Add Equ to + automatically implement equality members for classes. +- [#878](https://github.com/SMI/SmiServices/pull/878) by rkm. Update RDMP + packages with replacement of System.Data.SqlClient with + Microsoft.Data.SqlClient. Replace usages of same in codebase + +## Bugfix + +- [#764](https://github.com/SMI/SmiServices/pull/764) by howff. Clean up the + Python code lint after running pylint3 +- [#841](https://github.com/SMI/SmiServices/pull/841) by tznind. Fixed bug + when disposing `CsvDestination` instances that have not begun writing any + output +- [#880](https://github.com/SMI/SmiServices/pull/880) by tznind. Fixed edge + case in IdentifierMapper when a dicom tag has illegal multiplicity in + PatientID field + +## Meta + +- [#843](https://github.com/SMI/SmiServices/pull/843) by rkm. Add pre-commit + and codespell. Fix all current spelling mistakes +- [#844](https://github.com/SMI/SmiServices/pull/844) by rkm. Fixup regex in + codespell config +- [#855](https://github.com/SMI/SmiServices/pull/855) by rkm. Specify dotnet + SDK version in global.json +- [#859](https://github.com/SMI/SmiServices/pull/859) by rkm. Bump LangVersion + to 9.0 +- [#876](https://github.com/SMI/SmiServices/pull/876) by rkm. Add check and + error message for missing coveralls token +- [#877](https://github.com/SMI/SmiServices/pull/877) by rkm. Fix setting + replication for MongoDB in Windows CI pipelines + +## Removal + +- [#848](https://github.com/SMI/SmiServices/pull/848) by rkm. Removed + NationalPACSAccessionNumber from all metadata + ## [3.2.1] 2021-07-07 ## Bugfix @@ -928,7 +977,8 @@ First stable release after importing the repository from the private - Anonymous `MappingTableName` must now be fully specified to pass validation (e.g. `mydb.mytbl`). Previously skipping database portion was supported. -[unreleased]: https://github.com/SMI/SmiServices/compare/v3.2.1...master +[unreleased]: https://github.com/SMI/SmiServices/compare/v4.0.0...master +[4.0.0]: https://github.com/SMI/SmiServices/compare/v3.2.1...v4.0.0 [3.2.1]: https://github.com/SMI/SmiServices/compare/v3.2.0...v3.2.1 [3.2.0]: https://github.com/SMI/SmiServices/compare/v3.1.0...v3.2.0 [3.1.0]: https://github.com/SMI/SmiServices/compare/v3.0.2...v3.1.0 diff --git a/README.md b/README.md index a2e4c0fb4..f9f72f950 100644 --- a/README.md +++ b/README.md @@ -8,7 +8,7 @@ [![Total alerts](https://img.shields.io/lgtm/alerts/g/SMI/SmiServices.svg?logo=lgtm&logoWidth=18)](https://lgtm.com/projects/g/SMI/SmiServices/alerts/) -Version: `3.2.1` +Version: `4.0.0` # SMI Services diff --git a/docs/RELEASING.md b/docs/RELEASING.md index cc2bd5f15..093cee1a4 100644 --- a/docs/RELEASING.md +++ b/docs/RELEASING.md @@ -13,7 +13,7 @@ The release workflow is to checkout a new `release/` branch from master, update - Check that a [news file][news_files] is present for each merged PR since the previous release. To do this, checkout the latest `master` commit and list all the merged PRs since the last release, e.g.: ```console $ git checkout master && git pull - $ git log --oneline .. | grep -vP "dependabot|Bump" | grep -P '#\d+' + $ git log --oneline .. | grep -vP "dependabot|Bump|pre-commit-ci" | grep -P '#\d+' ec182696 Merge pull request #430 from SMI/feature/extraction-fixes 051a134e Merge pull request #444 from SMI/feature/trigger-updates 65fcfe41 Merge pull request #440 from SMI/feature/value-updater diff --git a/news/764-bugfix.md b/news/764-bugfix.md deleted file mode 100644 index 24050c8f9..000000000 --- a/news/764-bugfix.md +++ /dev/null @@ -1 +0,0 @@ -Clean up the Python code lint after running pylint3 diff --git a/news/841-bugfix.md b/news/841-bugfix.md deleted file mode 100644 index 12fcb8b04..000000000 --- a/news/841-bugfix.md +++ /dev/null @@ -1 +0,0 @@ -Fixed bug when disposing `CsvDestination` instances that have not begun writing any output \ No newline at end of file diff --git a/news/843-meta.md b/news/843-meta.md deleted file mode 100644 index 5d45b6b73..000000000 --- a/news/843-meta.md +++ /dev/null @@ -1 +0,0 @@ -Add pre-commit and codespell. Fix all current spelling mistakes diff --git a/news/844-meta.md b/news/844-meta.md deleted file mode 100644 index 55f09e7e8..000000000 --- a/news/844-meta.md +++ /dev/null @@ -1 +0,0 @@ -Fixup regex in codespell config diff --git a/news/848-removal.md b/news/848-removal.md deleted file mode 100644 index f1988da21..000000000 --- a/news/848-removal.md +++ /dev/null @@ -1 +0,0 @@ -Removed NationalPACSAccessionNumber from all metadata \ No newline at end of file diff --git a/news/849-feature.md b/news/849-feature.md deleted file mode 100644 index 8c5900f6a..000000000 --- a/news/849-feature.md +++ /dev/null @@ -1,5 +0,0 @@ -CTPAnonymiser refactoring -- Reduce memory footprint (issue #837) -- Simplify RabbitMQ message handling -- Stop creating temporary copy of input file - no longer needed in EPCC environment without Lustre FS (per issue #836) -- Add checks input file is readable not just extant, hopefully fixing issue #533 \ No newline at end of file diff --git a/news/855-meta.md b/news/855-meta.md deleted file mode 100644 index 01d0dd99c..000000000 --- a/news/855-meta.md +++ /dev/null @@ -1 +0,0 @@ -Specify dotnet SDK version in global.json diff --git a/news/859-meta.md b/news/859-meta.md deleted file mode 100644 index 0feff77ff..000000000 --- a/news/859-meta.md +++ /dev/null @@ -1 +0,0 @@ -Bump LangVersion to 9.0 diff --git a/news/861-feature.md b/news/861-feature.md deleted file mode 100644 index 08daadd18..000000000 --- a/news/861-feature.md +++ /dev/null @@ -1 +0,0 @@ -Add Equ to automatically implement equality members for classes. diff --git a/news/876-meta.md b/news/876-meta.md deleted file mode 100644 index 7ad3ef113..000000000 --- a/news/876-meta.md +++ /dev/null @@ -1 +0,0 @@ -Add check and error message for missing coveralls token diff --git a/news/877-meta.md b/news/877-meta.md deleted file mode 100644 index b4ccadd9a..000000000 --- a/news/877-meta.md +++ /dev/null @@ -1 +0,0 @@ -Fix setting replication for MongoDB in Windows CI pipelines diff --git a/news/878-feature.md b/news/878-feature.md deleted file mode 100644 index 9512a6bb6..000000000 --- a/news/878-feature.md +++ /dev/null @@ -1 +0,0 @@ -Update RDMP packages with replacement of System.Data.SqlClient with Microsoft.Data.SqlClient. Replace usages of same in codebase diff --git a/news/880-bugfix.md b/news/880-bugfix.md deleted file mode 100644 index dd3104713..000000000 --- a/news/880-bugfix.md +++ /dev/null @@ -1 +0,0 @@ -Fixed edge case in IdentifierMapper when a dicom tag has illegal multiplicity in PatientID field \ No newline at end of file diff --git a/src/SharedAssemblyInfo.cs b/src/SharedAssemblyInfo.cs index 11826901c..4c4b800c8 100644 --- a/src/SharedAssemblyInfo.cs +++ b/src/SharedAssemblyInfo.cs @@ -7,6 +7,6 @@ [assembly: AssemblyCulture("")] // These should be overwritten by release builds -[assembly: AssemblyVersion("3.2.1")] -[assembly: AssemblyFileVersion("3.2.1")] -[assembly: AssemblyInformationalVersion("3.2.1")] // This one can have the extra build info after it +[assembly: AssemblyVersion("4.0.0")] +[assembly: AssemblyFileVersion("4.0.0")] +[assembly: AssemblyInformationalVersion("4.0.0")] // This one can have the extra build info after it