Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Names for HS Institutions reference faker.name & faker.address #18

Open
allisonletts opened this issue Jan 24, 2022 · 2 comments
Open
Labels
enhancement New feature or request Hacktoberfest

Comments

@allisonletts
Copy link
Collaborator

Feature Description

I don't like the default Faker city name generator. My testing yielded names like "South Melissamouth High School" which is a problem with the city, not with the work you did here.

I also don't love that professional suffixes (MD, PhD, DVM, DDS) are included in the names sent back. I would have expected only professional prefixes.

Proposed Solution

City: pull an actual list of cities...
Names: define a separate namer that doesn't include professional suffixes, and sometimes has only initials for the first/middle name.

@acrosman
Copy link
Collaborator

For cities, unlike states, Faker actually generates the names. I didn't look into the pattern it uses in any detail so I don't know what elements get fed in. That means we'd have to create our own list instead of using a generated list. That would significantly reduce the size of the generated pool. Not a deal breaker, but worth considering.

For names, it absolutely should be broken into pieces to avoid the issues when full names are used.

@allisonletts
Copy link
Collaborator Author

allisonletts commented Jan 25, 2022

Here it is. They use first names as part of the city generation. I'd prefer to have a smaller list that wasn't quite so strange looking. https://github.com/joke2k/faker/blob/001ddee39c33b6b82196fe6a5ecc131bca3b964c/faker/providers/address/en_US/__init__.py#L445-L450

    city_formats = (
        "{{city_prefix}} {{first_name}}{{city_suffix}}",
        "{{city_prefix}} {{first_name}}",
        "{{first_name}}{{city_suffix}}",
        "{{last_name}}{{city_suffix}}",
    )

@acrosman acrosman added the enhancement New feature or request label Apr 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Hacktoberfest
Projects
None yet
Development

No branches or pull requests

2 participants