Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Global reference domain for offline analysis #2154

Merged
merged 2 commits into from
Oct 24, 2023
Merged

Global reference domain for offline analysis #2154

merged 2 commits into from
Oct 24, 2023

Conversation

akenmorris
Copy link
Contributor

This PR fixes the alignment reference domain in the offline analysis. Previously, the computed shapes would overlap:

Screen Shot 2023-10-21 at 12 30 14 AM

Now we use the global alignment:

Screen Shot 2023-10-21 at 12 37 36 AM

This PR also fixes the output location of the mean shape and particles (source vs target)

@akenmorris akenmorris requested a review from JakeWags October 21, 2023 06:39
JakeWags
JakeWags approved these changes Oct 24, 2023
View reviewed changes
Copy link
Contributor

@JakeWags JakeWags left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Seems like it'd be simple enough to change the Alignment type based on a command argument if we decide to go that path.

@JakeWags JakeWags mentioned this pull request Oct 24, 2023
Merged
7 tasks
@akenmorris akenmorris merged commit 79c277a into master Oct 24, 2023
4 checks passed
@akenmorris akenmorris deleted the analysis_fixes branch October 24, 2023 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JakeWags JakeWags JakeWags approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@akenmorris @JakeWags