Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect missing library dependency in manifest.json based on controls used in XML views/fragments #244

Open
flovogt opened this issue Aug 6, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@flovogt
Copy link
Member

flovogt commented Aug 6, 2024

I have an sap/ui/core/mvc/XMLView or an in XML defined sap/ui/core/Fragment. I am using a control e.g. sap/m/Text but I have forgotten to add the sap.m library to the sap.ui5/dependencies/lib array in the manifest.json.

View

<mvc:View xmlns:mvc="sap.ui.core.mvc" xmlns:core="sap.ui.core" xmlns="sap.m"controllerName="ui5app.controller.Home" >
  <Text text="Hello"/>
</mvc:View>

manifest.json

"sap.ui5": {
  "dependencies": {
      "minUI5Version": "1.121.0",
      "libs": {
        "sap.ui.core": {}
      }
}

Goal

This scenario is detected and an finding is reported to add the missing library dependency to the manifest.json.

@flovogt flovogt added the enhancement New feature or request label Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant