Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TBI - UITranslationInput. Improve i18n popover/callout #2551

Open
815are opened this issue Nov 11, 2024 · 2 comments
Open

TBI - UITranslationInput. Improve i18n popover/callout #2551

815are opened this issue Nov 11, 2024 · 2 comments
Labels
ui-components @sap-ux/ui-components

Comments

@815are
Copy link
Contributor

815are commented Nov 11, 2024

Description (include screenshots)

Currently when we click on globe button to trigger i18n generation, then we see popover:
image

Is scope of this task we should improve current UI based on latest design

ToDo - add more description

Value

Align with common design used in similar cases

Notes

Tasks

  • [ ]

@gpeuc

@815are 815are added the ui-components @sap-ux/ui-components label Nov 11, 2024
@gpeuc

This comment was marked as outdated.

@815are 815are changed the title TBI - UITranslationInput. Use modal dialog instead of popover/callout TBI - UITranslationInput. Improve i18n popover/callout Nov 25, 2024
@gpeuc
Copy link
Contributor

gpeuc commented Nov 26, 2024

Screenshot 2024-11-26 at 15 37 27

There's a general agreement to use inverted style mini in-line popup for this.

Also, we should fix some of the typography issues. There's a space missing after "file." before the word "Substitute". "by" → "with". The second sentence should be a question. It needs a question mark at the end. And then the buttons themselves then need to reflect the question, so "Apply" becomes "Substitute".

There's also a little bit of cleanup done on the boxes. 4px Border radius added to the box. 20px padding around the whole thing creating a frame.

Screenshot 2024-11-26 at 15 39 59 Screenshot 2024-11-26 at 15 40 46 Screenshot 2024-11-26 at 15 41 19

And the question is -- do we create another style for the inverted buttons, or we jut stick with current button-primary button-secondary?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ui-components @sap-ux/ui-components
Projects
None yet
Development

No branches or pull requests

2 participants