fix(servicemanager): improve Secret-Data error handling #52
+74
−16
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
The error message
BindingCredentials can't be created from invalid secret data
covers too many different scenarios.crossplane-provider-btp/internal/clients/servicemanager/api_plan_resolver.go
Lines 45 to 47 in 84d2f41
Solution:
This PR introduces more specific error messages that will be returned. It improves the user experience so that users can figure out the cause of the issue.