-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor system tests to use the new FTP server and to run in pytest #301
Conversation
and improve debug logging.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀 This is looking great!
if any debugging commands work
stale review and happy for the rest of the team to decide if this is ready to go in
Thanks to those who've already had a look at this. I believe it is now actually ready to go in. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for getting this in Jeremy, so much fun with FTP
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀 works like a charm locally!
To fix #293
Well, this was a journey.
A simple refactor of the system (E2E) test ran into a few problems:
This explains some of the awkward workarounds in this PR.
Hopefully the benefits of moving it into pytest and having a non-flaky FTP server were worth it...
TODOs: