Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Rabbitmq version to 3.12 #286

Merged
merged 9 commits into from
Feb 14, 2024
Merged

Update Rabbitmq version to 3.12 #286

merged 9 commits into from
Feb 14, 2024

Conversation

ruaridhg
Copy link
Contributor

@ruaridhg ruaridhg commented Feb 7, 2024

Updated rabbitmq version to 3.12-management in tests for modules:

  • pixl imaging
  • cli
  • core
  • system

Needed to export DOCKER_DEFAULT_PLATFORM=linux/arm64 for it to work on Mac M1

@ruaridhg ruaridhg changed the title Rmg/fix docker imaging Update Rabbitmq version to 3.12 Feb 7, 2024
@ruaridhg ruaridhg marked this pull request as ready for review February 7, 2024 17:09
@ruaridhg ruaridhg force-pushed the rmg/fix-docker-imaging branch from b6f6bd4 to 3d1f7aa Compare February 7, 2024 17:19
@ruaridhg ruaridhg requested a review from a team February 7, 2024 17:28
Copy link
Contributor

@stefpiatek stefpiatek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be good to check that we need to specify the platform locally

pixl_imaging/tests/docker-compose.yml Outdated Show resolved Hide resolved
@stefpiatek
Copy link
Contributor

stefpiatek commented Feb 13, 2024

Happy for you to merge once you've resovled the conflicts

@ruaridhg ruaridhg merged commit ade975c into main Feb 14, 2024
8 checks passed
@ruaridhg ruaridhg deleted the rmg/fix-docker-imaging branch February 14, 2024 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants