Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow orthanc anon to run without connecting to Azure #295

Closed
3 tasks
stefpiatek opened this issue Feb 12, 2024 · 2 comments · Fixed by #299
Closed
3 tasks

Allow orthanc anon to run without connecting to Azure #295

stefpiatek opened this issue Feb 12, 2024 · 2 comments · Fixed by #299
Assignees
Milestone

Comments

@stefpiatek
Copy link
Contributor

stefpiatek commented Feb 12, 2024

Definition of Done / Acceptance Criteria

  • Orthanc anon can be configured not to try to connect to azure (as this currently blocks upload work)
    • .env file should be able to configure where whether we ever try to connect to azure
    • pixl.py plugin in orthanc anon uses the variable to gate connection to azure
      • AzureDICOMTokenRefresh and AzureAccessToken should not be run if the config disables it

Testing

No response

Documentation

No response

Dependencies

No response

Details and Comments

Had done some commenting out of code to get test out upload into DSH in pixl_test, should have a long term solution for this

@stefpiatek stefpiatek added this to the VOXL milestone Feb 12, 2024
@milanmlft
Copy link
Member

So this is why I added https://github.com/UCLH-Foundry/PIXL/blob/044286040f88d3219c35a2a46ea14a2e4705e17e/orthanc/orthanc-anon/plugin/pixl.py#L217-L219 in #268. _azure_available() checks if the AZ_DICOM_ENDPOINT_CLIENT_ID env variable is set, and if it's not then AzureDICOMTokenRefresh doesn't get called. But might have missed something. Which lines of code did you have to comment out to get it to work?

@stefpiatek
Copy link
Contributor Author

Yeah that's what I said about missing it that method existed when chatting about it in our standup. Only thing to do on this ticket now is to make sure that's documented which is incoming

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants