Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propagate Orthanc logs when system test fails #275

Closed
milanmlft opened this issue Jan 31, 2024 · 3 comments
Closed

Propagate Orthanc logs when system test fails #275

milanmlft opened this issue Jan 31, 2024 · 3 comments
Labels
dev-velocity Working on the issue will increase development speed in the long run

Comments

@milanmlft
Copy link
Member

Definition of Done / Acceptance Criteria

The (relevant parts of the) Orthanc logs are displayed in the CI output when one of the checks fails.

Testing

No response

Documentation

No response

Dependencies

No response

Details and Comments

At the moment, some of the system test checks might fail because of something going wrong during the Orthanc processing, but requires re-running locally and manually inspecting the logs to find out what.
Would be nice if we could see this immediately in the CI output.

@milanmlft milanmlft added the dev-velocity Working on the issue will increase development speed in the long run label Jan 31, 2024
@stefpiatek
Copy link
Contributor

yeah could have a function which runs docker compose logs on the production components if there's a non zero exit and then propogates the exit code would be good.

@milanmlft
Copy link
Member Author

Not sure how to make Orthanc return an non-zero exit code from the plugin though, I've tried adding raise SystemExit in try/except blocks, e.g. when it fails to connect to the FTP server, but that doesn't make the Orthanc service fail, it just shows up in the logs.

@milanmlft
Copy link
Member Author

Done in #301

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev-velocity Working on the issue will increase development speed in the long run
Projects
None yet
Development

No branches or pull requests

2 participants