Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow PIXL DB tables to be updated in production #270

Closed
1 task
stefpiatek opened this issue Jan 31, 2024 · 1 comment · Fixed by #298
Closed
1 task

Allow PIXL DB tables to be updated in production #270

stefpiatek opened this issue Jan 31, 2024 · 1 comment · Fixed by #298
Assignees
Milestone

Comments

@stefpiatek
Copy link
Contributor

Definition of Done / Acceptance Criteria

  • instead of creating tables from sqlalchemy in postgres/create_pixl_tbls.py, use define the tables in alembic migrations and run them before we run the imaging-api/pacs-api server as part of the run command

Testing

shouldn't need any changing

Documentation

Add documentation on alembic being used for the postgres service

Dependencies

No response

Details and Comments

  • We expect that the pixl DB will change over time, and want to handle this in an automated way that we can test with development versions
  • Because we're defining our tables in sqlachemy, alembic is a straightforward choice. Its a bit of duplication of information, but does mean that we can update our production database in a controlled way with rollbacks if required
  • the imaging pipeline is the only part that depends on the pipeline tables, so running this on startup of the container makes sense
@stefpiatek stefpiatek added this to the VOXL milestone Jan 31, 2024
@jstutters
Copy link
Contributor

@stefpiatek stefpiatek linked a pull request Feb 14, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants