Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PIXL pipeline: Update python version to 3.12 #195

Open
9 tasks done
stefpiatek opened this issue Nov 17, 2023 · 7 comments
Open
9 tasks done

PIXL pipeline: Update python version to 3.12 #195

stefpiatek opened this issue Nov 17, 2023 · 7 comments
Labels
dev-velocity Working on the issue will increase development speed in the long run

Comments

@stefpiatek
Copy link
Contributor

stefpiatek commented Nov 17, 2023

Definition of Done / Acceptance Criteria

To maintain python support during life of PIXL project.

PIXL modules currently running on python 3.9 and 3.10. Should update these to 3.12 where we can.

Sadly orthanc seems to be always have Docker containers with 3.9 so may need to accept that for now in pixl_dcmd

Testing

Tests pass, and carry out a test run on the GAE

  • core
  • cli
  • ehr-api
  • imaging-api
  • pixl_dcmd (Orthanc still requires 3.9)
  • hasher
  • pytest-pixl
  • system-test
  • Test run on GAE

Documentation

No response

Dependencies

No response

Details and Comments

  • Update pydantic to latest version and replace validator with field_validator

As part of #309, we're using pydantic.validator, however in pydantic>=2.0 the recommended method is to use pydantic.field_validator.

@stefpiatek stefpiatek changed the title Update python version to 3.12 PIXL pipeline: Update python version to 3.12 Nov 20, 2023
@stefpiatek stefpiatek transferred this issue from another repository Dec 18, 2023
@stefpiatek stefpiatek added this to the 100-days milestone Dec 18, 2023
@milanmlft
Copy link
Member

PyYAML 6.0 gives installation errors on 3.12.
Do we still need PyYAML though? If yes, should increase version requirement to 6.0.1

@stefpiatek
Copy link
Contributor Author

I think yeah we do need it actually, let's update to 6.0.1

@stefpiatek stefpiatek modified the milestones: 100-days, VOXL Jan 29, 2024
@stefpiatek stefpiatek added dev-velocity Working on the issue will increase development speed in the long run and removed dev-velocity Working on the issue will increase development speed in the long run labels Jan 29, 2024
@jstutters
Copy link
Contributor

#267 solves the PyYAML problem but can't do anything about the Python version bundled with the Orthanc Docker image which acts as a constraint on pixl_core and pixl_dcmd.

@stefpiatek
Copy link
Contributor Author

orthancteam/orthanc has been documented as the successor to osimis/orthanc which is no longer being updated. Still python 3.9.2 but hopefully that should mean there'll be newer releases soon

@stefpiatek stefpiatek removed this from the VOXL milestone Feb 28, 2024
@milanmlft milanmlft added the dev-velocity Working on the issue will increase development speed in the long run label Mar 4, 2024
@milanmlft milanmlft self-assigned this Mar 4, 2024
@milanmlft
Copy link
Member

Confirmation that Orthanc should move to Python 3.11 soon: orthanc-server/orthanc-builder#19 (comment)

@milanmlft
Copy link
Member

Orthanc containers have been updated to Python 3.11! 🎉
https://github.com/orthanc-server/orthanc-builder/blob/master/release-notes-docker-images.md#2433

@milanmlft
Copy link
Member

Orthanc containers have been updated in #339

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev-velocity Working on the issue will increase development speed in the long run
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants