Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FTP should allow more connections #13

Open
GXTX opened this issue Jan 7, 2023 · 2 comments
Open

FTP should allow more connections #13

GXTX opened this issue Jan 7, 2023 · 2 comments

Comments

@GXTX
Copy link
Contributor

GXTX commented Jan 7, 2023

Currently limited to 2 which means single transfers. With large small file transfers this makes things quite slow.
@GXTX
Copy link
Contributor Author

GXTX commented Jan 8, 2023 •
edited
Loading

Changed this to 5 and it just worked(tm), higher it likes to stall connections. Any reason you have it so low? https://github.com/Ryzee119/LithiumX/blob/master/src/lib/ftpd/ftp.h#L38

Edit: Nvm :P Weird stuff happening after ~6k files.

@Ryzee119
Copy link
Owner

Ryzee119 commented Jan 8, 2023 •
edited
Loading

You need to increase MEMP_NUM_NETBUF, MEMP_NUM_NETCONN variables I believe to match the max number of clients.

-DMEMP_NUM_NETBUF=6, -DMEMP_NUM_NETCONN=6 in CFLAGS for example, but it does still get confused sometimes. Not really sure why yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@GXTX @Ryzee119