Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: New notes not synced since Memos 0.23.0 #36

Open
asturale opened this issue Dec 17, 2024 · 3 comments
Open

[BUG]: New notes not synced since Memos 0.23.0 #36

asturale opened this issue Dec 17, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@asturale
Copy link

obsidian-memos-sync Version

0.4.3

Memos Server Version

0.23.0

Behavior

Since updating to memos 0.23.0, new memos aren't synced anymore to Obsidian. Old memos are still updated. Console log shows no errors.

Additional Context

Console shows:
Syncing daily memos...
Synced daily memos, lastTime: 1734439293000

lastTime doesn't change but stays the same when syncing multiple times.

Forced sync doesn't make a difference.

I tried removing and re-installing the plugin without effect.

@asturale asturale added the bug Something isn't working label Dec 17, 2024
@RyoJerryYu
Copy link
Owner

It is because Memos 0.23.0 introduced a non-backward compatible API update. I'll update the plugin for compatibility as soon as I can, but it will take time due to my current busy schedule.

@asturale
Copy link
Author

asturale commented Dec 18, 2024

I fixed it for myself for now by changing line 4782 in main.js (in var MemosPaginator0220) from

filter: "";

to

filter: "creator == 'users/1' && visibilities == ['PRIVATE', 'PUBLIC', 'PROTECTED']";

I don't know if this is the best place to fix and how to request the userid of the authenticated user.
If I figure it out I'll try to make a pull request.

@ccinoo
Copy link

ccinoo commented Dec 31, 2024

我现在自己修复了这个问题,方法是将 main.js 中的第 4782 行(在 var MemosPaginator0220 中)从-----------谷歌翻译----------我现在通过将 main.js 中的第 4782 行(在 var MemosPaginator0220 中)从

filter: "";

到-----------谷歌翻译------------到

filter: "creator == 'users/1' && visibilities == ['PRIVATE', 'PUBLIC', 'PROTECTED']";

我不知道这是否是最佳修复位置以及如何请求经过身份验证的用户的用户 ID。 如果我弄明白了,我会尝试发出拉取请求。-----------谷歌翻译------------我不知道这是否是最佳修复位置以及如何请求通过身份验证的用户的用户ID。如果我弄清楚了,我会尝试提出拉取请求。

Good idea, it can be synchronized after modification.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants