Change use_scroll RTL to signal

RustForWeb · Apr 7, 2024 · 771370d · 771370d
1 parent 3558ae7
commit 771370d
Show file tree

Hide file tree

Showing 6 changed files with 7 additions and 8 deletions.
diff --git a/packages/leptos/tests/visual/src/spec/arrow.rs b/packages/leptos/tests/visual/src/spec/arrow.rs
@@ -77,7 +77,7 @@ pub fn Arrow() -> impl IntoView {
         reference_ref,
         floating_ref,
         update,
-        rtl: None,
+        rtl: None::<bool>.into(),
     });
 
     let placement_update_scroll = update_scroll.clone();

diff --git a/packages/leptos/tests/visual/src/spec/auto_placement.rs b/packages/leptos/tests/visual/src/spec/auto_placement.rs
@@ -89,7 +89,7 @@ pub fn AutoPlacement() -> impl IntoView {
         reference_ref,
         floating_ref,
         update,
-        rtl: None,
+        rtl: None::<bool>.into(),
     });
 
     view! {

diff --git a/packages/leptos/tests/visual/src/spec/scroll.rs b/packages/leptos/tests/visual/src/spec/scroll.rs
@@ -42,7 +42,7 @@ pub fn Scroll() -> impl IntoView {
         reference_ref,
         floating_ref,
         update,
-        rtl: None,
+        rtl: None::<bool>.into(),
     });
 
     let reference_view = move || {

diff --git a/packages/leptos/tests/visual/src/spec/shift.rs b/packages/leptos/tests/visual/src/spec/shift.rs
@@ -105,7 +105,7 @@ pub fn Shift() -> impl IntoView {
         reference_ref,
         floating_ref,
         update,
-        rtl: None,
+        rtl: None::<bool>.into(),
     });
 
     view! {

diff --git a/packages/leptos/tests/visual/src/spec/size.rs b/packages/leptos/tests/visual/src/spec/size.rs
@@ -95,8 +95,7 @@ pub fn Size() -> impl IntoView {
         reference_ref,
         floating_ref,
         update,
-        // TODO: reactive?
-        rtl: Some(rtl()),
+        rtl: rtl.into(),
     });
 
     view! {

diff --git a/packages/leptos/tests/visual/src/utils/use_scroll.rs b/packages/leptos/tests/visual/src/utils/use_scroll.rs
@@ -13,7 +13,7 @@ pub struct UseScrollOptions {
     pub reference_ref: NodeRef<Div>,
     pub floating_ref: NodeRef<Div>,
     pub update: Rc<dyn Fn()>,
-    pub rtl: Option<bool>,
+    pub rtl: MaybeProp<bool>,
 }
 
 pub struct UseScrollReturn {
@@ -103,7 +103,7 @@ pub fn use_scroll(
                 let y = scroll.scroll_height() / 2 - scroll.offset_height() / 2;
                 log::info!("x {x} | y {y}");
                 scroll.set_scroll_top(y);
-                scroll.set_scroll_left(match rtl {
+                scroll.set_scroll_left(match rtl() {
                     Some(true) => -x,
                     _ => x,
                 })