From e1bdc05cae0f921fbbde484d25461ce3aeb612fc Mon Sep 17 00:00:00 2001
From: Artyom Pavlov <newpavlov@gmail.com>
Date: Fri, 22 Sep 2023 20:09:57 +0300
Subject: [PATCH] cipher: mark set_pos_unchecked private method as unsafe
 (#1346)

---
 cipher/src/stream_wrapper.rs | 22 +++++++++++++++++++---
 1 file changed, 19 insertions(+), 3 deletions(-)

diff --git a/cipher/src/stream_wrapper.rs b/cipher/src/stream_wrapper.rs
index e3495bc14..fb128389f 100644
--- a/cipher/src/stream_wrapper.rs
+++ b/cipher/src/stream_wrapper.rs
@@ -64,8 +64,13 @@ where
         T::BlockSize::USIZE
     }
 
+    /// Set buffer position without checking that it's smaller
+    /// than buffer size.
+    ///
+    /// # Safety
+    /// `pos` MUST be smaller than `T::BlockSize::USIZE`.
     #[inline]
-    fn set_pos_unchecked(&mut self, pos: usize) {
+    unsafe fn set_pos_unchecked(&mut self, pos: usize) {
         debug_assert!(pos < T::BlockSize::USIZE);
         self.pos = pos as u8;
     }
@@ -124,7 +129,13 @@ where
             let n = data.len();
             if n < rem.len() {
                 data.xor_in2out(&rem[..n]);
-                self.set_pos_unchecked(pos + n);
+                // SAFETY: we have checked that `n` is less than length of `rem`,
+                // which is equal to buffer length minus `pos`, thus `pos + n` is
+                // less than buffer length and satisfies the `set_pos_unchecked`
+                // safety condition
+                unsafe {
+                    self.set_pos_unchecked(pos + n);
+                }
                 return Ok(());
             }
             let (mut left, right) = data.split_at(rem.len());
@@ -140,7 +151,12 @@ where
             self.core.write_keystream_block(&mut self.buffer);
             leftover.xor_in2out(&self.buffer[..n]);
         }
-        self.set_pos_unchecked(n);
+        // SAFETY: `into_chunks` always returns tail with size
+        // less than buffer length, thus `n` satisfies the `set_pos_unchecked`
+        // safety condition
+        unsafe {
+            self.set_pos_unchecked(n);
+        }
 
         Ok(())
     }