Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix leak of temporary GL context on windows #199

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

glowcoil
Copy link
Member

@glowcoil glowcoil commented Nov 18, 2024

Creating a modern OpenGL context on Windows requires first creating a temporary context, using it to load some function pointers (e.g. wglCreateContextAttribsARB), and then using those to create the actual context. In Baseview's case, the temporary context was not being deleted afterwards, resulting in a resource leak.

@prokopyl prokopyl force-pushed the fix-gl-context-leak branch from 8620182 to 8b27675 Compare December 5, 2024 16:10
@glowcoil glowcoil merged commit 21fdc89 into RustAudio:master Dec 5, 2024
3 checks passed
@glowcoil glowcoil deleted the fix-gl-context-leak branch December 5, 2024 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants