From fc180ff23c312b07f0682873ad2a55c51f820eea Mon Sep 17 00:00:00 2001 From: max Date: Mon, 13 May 2024 22:20:39 +0300 Subject: [PATCH] address review comments --- src/macos/window.rs | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/src/macos/window.rs b/src/macos/window.rs index d9e1938..f9f19fb 100644 --- a/src/macos/window.rs +++ b/src/macos/window.rs @@ -389,7 +389,7 @@ impl WindowState { let mut window = crate::Window::new(Window { inner: &self.window_inner }); let mut window_handler = self.window_handler.borrow_mut(); let status = window_handler.on_event(&mut window, event); - self.trigger_deferred_events(window_handler.as_mut()); + self.send_deferred_events(window_handler.as_mut()); status } @@ -400,6 +400,7 @@ impl WindowState { if let Ok(mut window_handler) = self.window_handler.try_borrow_mut() { let mut window = crate::Window::new(Window { inner: &self.window_inner }); window_handler.on_event(&mut window, event); + self.send_deferred_events(window_handler.as_mut()); } else { self.deferred_events.borrow_mut().push_back(event); } @@ -408,7 +409,7 @@ impl WindowState { pub(super) fn trigger_frame(&self) { let mut window = crate::Window::new(Window { inner: &self.window_inner }); let mut window_handler = self.window_handler.borrow_mut(); - self.trigger_deferred_events(window_handler.as_mut()); + self.send_deferred_events(window_handler.as_mut()); window_handler.on_frame(&mut window); } @@ -444,9 +445,9 @@ impl WindowState { (*window_state_ptr).frame_timer.set(Some(timer)); } - fn trigger_deferred_events(&self, window_handler: &mut dyn WindowHandler) { + fn send_deferred_events(&self, window_handler: &mut dyn WindowHandler) { let mut window = crate::Window::new(Window { inner: &self.window_inner }); - for event in self.deferred_events.borrow_mut().drain(..) { + while let Some(event) = self.deferred_events.borrow_mut().pop_front() { window_handler.on_event(&mut window, event); } }