Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shadow Shinys #39

Open
ghost opened this issue May 3, 2020 · 3 comments
Open

Shadow Shinys #39

ghost opened this issue May 3, 2020 · 3 comments
Labels
enhancement New feature or request

Comments

@ghost
Copy link

ghost commented May 3, 2020

Shadow shinys are missing in the list

@Rplus Rplus added the enhancement New feature or request label May 4, 2020
@Rplus
Copy link
Owner

Rplus commented May 4, 2020

There is no shadow pokemon image in PogoAssets, so that will be a problem to show images.

@nickpl456
Copy link
Contributor

So it looks like with a shiny shadow the game uses the normal shiny image/3d assets. In the normal pokemon storage view it just puts the shadow flame in the lower corner without recoloring the eyes (https://github.com/ZeChrales/PogoAssets/blob/ea5132eb0f8cd7481dc2db999ca3d85e3879a40b/static_assets/png/ic_shadow.png) and only when the game loads the 3d model does it recolor their eyes red.

All that to say would it be acceptable to just overlay/underlay the shadow symbol on shiny shadow pokemon and accept that the eye color will be wrong?

Or is there some way we could clone the images from PogoAsset and recolor the eyes and add the shadow flame (I'd be willing to do the image work, just not sure about the legality of it).

@Rplus
Copy link
Owner

Rplus commented May 14, 2020

It might be okay to use shadow icon now.

There will be more shiny items,
and I think this list needs to re-design with more options for controlling "range":

  • gen1, gen2, gen3...
  • legendary
  • eggsonly
  • different forms
  • costume
  • shadow
  • male / female

But I'm not good at UI design,
it might take some time to refactor that. :P

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants