-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ssr): poc #17
feat(ssr): poc #17
Conversation
Ey @gabrielperales thanks for your mr I hope to check it tomorrow! I have one question, you added babel to be able to transform the classes in the JS server files, it isn't? |
@gabrielperales which errors did you have with yarn? I could install it and the build works |
Exactly. If was just using the regex over the |
I don't remember. Nothing important, but I didn't want to deal with that I tried to make it work as fast as I can 😅 |
Yeah, I had a similar issue in one of my projects. In my html the package remove the flex word and replace with the minified class. Could you add a test for your use case? Or give me an example to make it |
@all-contributors please add @gabrielperales for code |
I've put up a pull request to add @gabrielperales! 🎉 |
I'm not sure if this is the right approach, actually, I think the code should be in the
astro:build:done
hook, but this code is working for me, so maybe we can use it as a starting point for SSR.Sorry about changing from yarn to npm, but I was struggling with something related to the package manager and I decided to switch it to NPM. I imagine we can delete those changes from the MR.