Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adaption for Asteroid #30

Open
elmarti opened this issue Mar 13, 2018 · 6 comments
Open

Adaption for Asteroid #30

elmarti opened this issue Mar 13, 2018 · 6 comments

Comments

@elmarti
Copy link

elmarti commented Mar 13, 2018

I am extending my video chat extension to work as an Asteroid (Alternative Meteor Client) mixin and at present, this package is a dependency. Is there any desire for this to be extended to work with Asteroid (I have done most of the work, I can create a PR if need be).

@elmarti
Copy link
Author

elmarti commented Mar 13, 2018

Here is the video chat extension for anyone interested https://github.com/elmarti/meteor-video-chat

@elmarti
Copy link
Author

elmarti commented Mar 13, 2018

A simple fix would be to inject the what is currently the Meteor object, which should be reusable verbatim by the Asteroid instance.

elmarti pushed a commit to elmarti/meteor-streamer that referenced this issue Mar 13, 2018
elmarti pushed a commit to elmarti/meteor-streamer that referenced this issue Mar 14, 2018
elmarti pushed a commit to elmarti/meteor-streamer that referenced this issue Mar 14, 2018
@elmarti
Copy link
Author

elmarti commented Mar 14, 2018

Tested on Meteor, still awaiting testing in the MeteorVideoChat Asteroid conversion. I get that this is a big change to the project, this could be released to NPM as a fork if you have no desire to merge it.

@elmarti
Copy link
Author

elmarti commented Mar 20, 2018

Closing due to lack of interest. If anyone needs advice on integrating this package with Asteroid, just ask.

@elmarti elmarti closed this as completed Mar 20, 2018
@timkinnane
Copy link

@elmarti There are very useful contributions and discussions that go stagnant on here sometimes for a year or more. I wouldn't take the 7 days of inactivity as a sign its unwanted. There's a lot going on currently with the core team and I'm sure if you left this open it would get some attention at some point. I am also working on a project that implements Asteroid Node.js SDK for bot adapters. Currently it's using Asteroid v1 because that was already in use and I didn't have time to update and test with the v2 mixin for DDP. So I'd be keen to see examples of other Asteroid mixins when I come back to that update.

@elmarti
Copy link
Author

elmarti commented Mar 21, 2018

Ok great, I didn't want to persevere if there's no desire at all, in the mean time I dropped the client code straight into my extensions, but I guess I'll try and get this merged once it's ready :)

@elmarti elmarti reopened this Mar 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants