WIP: Introduce StoreUpdateGate, for temporarily blocking store updates for its descendants
#7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LPGhatguy
commented
May 7, 2018
lib/GatedSignal.lua
Outdated
| @@ -0,0 +1,107 @@ | |||
| --[[ | |||
| A limited, simple implementation of a GatedSignal with the addition of a | |||
| gated condition. | |||
There was a problem hiding this comment.
Ouch, that comment got butchered by find-and-replace.
tiffany352
reviewed
May 29, 2018
lib/StoreUpdateGate.lua
Outdated
| if self.props.shouldBlockUpdates then | ||
| self.stateAtLastBlock = self.realStore:getState() | ||
| else | ||
| self.mockStore.changed:fire(self.realStore:getState(), self.stateAtLastBlock) |
There was a problem hiding this comment.
Shouldn't this check if the oldState ~= newState before firing? Does Rodux itself do this?
|
I believe we have concluded internally that this functionality is hard to implement correctly and is of dubious utility. As such, I'm closing this PR! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6.
Introduces a new component named
StoreUpdateGate(name subject to change) that exposes a mock store for all connections below it in the tree.The prop
shouldBlockUpdates(name also subject to change) determines whether theStoreUpdateGatewill pass on any Rodux store updates, or instead swallow them. WhenshouldBlockUpdatesreturns totruewhen it was previouslyfalse, a single update will be dispatched to all children.