Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update license file so that GitHub properly understands that it is Apache 2.0 #168

Closed
wants to merge 1 commit into from
Closed

Update license file so that GitHub properly understands that it is Apache 2.0 #168

wants to merge 1 commit into from

Conversation

slonopotamus
Copy link
Contributor

Previously, the whole license text was duplicated.

@slonopotamus
Update license file so that GitHub properly understands that it is Ap…
a5f6ea0 
…ache 2.0

Previously, the whole license text was duplicated.
shishir-a412ed
shishir-a412ed approved these changes Mar 13, 2024
View reviewed changes
Copy link
Contributor

@shishir-a412ed shishir-a412ed left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just checked the LICENSE, it seems to be correct. What is duplicated?
I also checked the LICENSE file in other Roblox projects and they seem to be matching to the one in this repository.

Going to close this one for now.

@slonopotamus
Copy link
Contributor Author

slonopotamus commented Mar 14, 2024 •
edited
Loading

https://github.com/Roblox/nomad-driver-containerd/blob/master/LICENSE#L9

"License" shall mean the terms and conditions for use, reproduction,

https://github.com/Roblox/nomad-driver-containerd/blob/master/LICENSE#L182

"License" shall mean the terms and conditions for use, reproduction,

You have lines 2...174 duplicated again on 175...347.

I also checked the LICENSE file in other Roblox projects and they seem to be matching to the one in this repository.

No, they don't match. https://github.com/Roblox/nomad-driver-iis/blob/master/LICENSE has 201 lines. File in current repo has 347.

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 14, 2024 •
edited
Loading

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@slonopotamus
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shishir-a412ed shishir-a412ed shishir-a412ed approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@slonopotamus @shishir-a412ed