Refactoring #68
Merged
Refactoring #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I fixed most of the typing issues under pylint --strict.
1.1 This required unifying the interface of
step,step_env,get_obs, 'is_terminal` for proper inheritance.spacesnow depends ongymnasiuminstead ofgym, adding an additional dependency. Maybe later ongymdependency can be completely removed since it's not maintained anymore? haven't looked into that.I removed
_DeviceArrayfrom the tests as it's deprecated. I use jax version0.4.24I ran everything in
python 3.10so technically you could support that too now.In
wrapper/brax.py,GymnaxtoBraxWrapperhas two new methodsbackendandobservation_size, as its required to be defined under newest brax version. I used brax version0.10.0.