Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edge store not working #128

Open
neoOpus opened this issue Mar 10, 2023 · 1 comment
Open

Edge store not working #128

neoOpus opened this issue Mar 10, 2023 · 1 comment

Comments

@neoOpus
Copy link

neoOpus commented Mar 10, 2023

I've seen in the issues and comments that you've added MS Edge Extensions Store but for some reason the icon is greyed out and the only way to download with it is to use the inspect pop-up window and click over the button on the popup who throw an error

A theme

Network error for https://edge.microsoft.com/extensionwebstorebase/v1/crx?response=redirect&x=id%3Djnegjmlkajgpjloaanncielldhcedhcp%26installsource%3Dondemand%26uc

The same for extension

Network error for https://edge.microsoft.com/extensionwebstorebase/v1/crx?response=redirect&x=id%3Dkagpabjoboikccfdghpdlaaopmgpgfdc%26installsource%3Dondemand%26uc

The URL is fine, I downloaded the files and added .crx to them…

I guess MS changed something on their Store… please let me know, I can provide additional information to get this fixed.

PS: I find that Dev Tools has a great code viewer with highlight that performs pretty well, maybe this inspires you to refactor this extension based on it (if it is possible of course)

@Rob--W
Copy link
Owner

Rob--W commented Dec 10, 2023

There are three separate requests in this report. One of them I'm going to fix, the second one is something I cannot reproduce, and the third one is out of scope for this defect report.

I've seen in the issues and comments that you've added MS Edge Extensions Store but for some reason the icon is greyed out

This was a regression introduced in 2037153 and first included in version 1.6.12.
I'm going to add a commit that fixes this part, which will be part of the next update (1.7.1 - does not exist yet as of writing).

Test case: https://microsoftedge.microsoft.com/addons/detail/pantone-color-of-the-year/jnegjmlkajgpjloaanncielldhcedhcp

Network error for https://edge.microsoft.com/extensionwebstorebase/v1/crx?response=redirect&x=id%3Djnegjmlkajgpjloaanncielldhcedhcp%26installsource%3Dondemand%26uc

I cannot reproduce this issue. Did you grant the extension access to any URL by clicking the "Add permission" button in the crxviewer UI?

PS: I find that Dev Tools has a great code viewer with highlight that performs pretty well, maybe this inspires you to refactor this extension based on it (if it is possible of course)

That's a separate feature request. I don't have time to look into that right now, but if you think that the highlighting is superior, feel free to open a new issue with the feature request.

Rob--W added a commit that referenced this issue Dec 10, 2023
Fixes typo that prevented the extension button from being clickable at
the Edge gallery in the Chrome extension (and Opera extension).
The Firefox add-on is not affected.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants