-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The game crashes when using Potion arrows #523
Comments
theories:
OR, what is more likely:
|
This is PotionColorizer download address: https://github.com/EasyMFnE/PotionColorizer/ |
It's not immediately obvious to me why this mod breaks |
My guess it must be changing the icon somewhere. There is this huge black box of reflection in the mod that it is hard to tell what it is actually doing. But if it's making assumptions about what the iicon is that doesn't work with modded potions that'd cause it. Our tipped arrows are in compliance with the same metas regular potions are. Does this mod break lingering potions too? |
no, it only destroys the potion arrow |
These are some interesting tricks in reflection I've never seen before. Hey Greg, is this reflection effectively overwriting code in the methods? That does seem pretty cool, although I can't find out why it breaks at the moment. |
Edit -- ignore that, i tested my theory and it doesnt crash -- |
thanks! |
Initial Questions
Mod Version
etfuturum-2.6.0-master.59+0989b2b0f2
Describe the Issue
Crash when clicking Potion Arrow
2024-09-22.07-22-15.mp4
Conflicting Mods
No response
Crash Report
https://pastebin.com/wRqq9rdH
Other Details
The text was updated successfully, but these errors were encountered: