Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flow-control statements in FINALLY block rule does not raise an issue if FINALLY block, or flow-control statement, is inside the include #1128

Open
Ton-Pe opened this issue May 28, 2024 · 2 comments

Comments

@Ton-Pe
Copy link

Ton-Pe commented May 28, 2024

Quite a minor issue, but wanted to report this. If the whole finally block, or flow-control statement, is inside an include file the error is not shown.

For example, this is not reported as an error:
test.p

DEFINE VARIABLE xError AS LOGICAL NO-UNDO.

{finally.i}

finally.i

FINALLY:
   IF xError THEN RETURN ERROR.
END FINALLY.

Neither is this:
test.p

DEFINE VARIABLE xError AS LOGICAL NO-UNDO.

FINALLY:
   {finally.i}
END FINALLY.

finally.i

   IF xError THEN RETURN ERROR.

Following code works as expected and error is reported:

DEFINE VARIABLE xError AS LOGICAL NO-UNDO.

FINALLY:
   IF xError THEN RETURN ERROR.
END FINALLY.
@gquerret
Copy link
Contributor

Is that in SonarLint or in SonarQube ?

@Ton-Pe
Copy link
Author

Ton-Pe commented May 29, 2024

First problem, at least, is in both. Second example was tested only in Sonarlint.

OE plugin installed is 2.26.1. SonarQube version v9.9.5. OpenEdge 12.8 and SonarLint 9.3.3006

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants