-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OS X Thread Affinity is unimplemented #18
Comments
Curious: what is the status of this issue? Did it ever get attention? |
It's stalled. I haven't heard back from underscorediscovery. That said, my brief look into OSX thread affinity suggests that it's not possible from the kernel level. OSX purposely doesn't allow you to set the affinity. |
Hey apparently I slept on this. |
If my local build of this still compiles I can try update and PR for that piece, was there a test (to confirm affinity) in place @RichieSams? |
Not currently, but I could whip one up this week. It would just spin up threads and compare their thread ids to check uniqueness. |
@RichieSams that'd be helpful, I think it'd make sure it's consistent on all targets going forward. |
Definitely. Will do |
Thanks, a ton, you two. My small team will be experimenting with Fibers and perhaps we can assist with some of the other open issues. |
Awesome! |
Affinity tests for Windows and Linux are implemented: https://github.com/RichieSams/FiberTaskingLib/tree/test_updates |
Alright cool, I'll use that as a jumping point. |
OSX Affinity is theoretically implemented. It needs the tests though. And verification that I did it right. I've only tried it on a VM. |
ah ok, missed that bit, I'll have a run at it |
I've made progress on this and will PR soon with an implementation.
The text was updated successfully, but these errors were encountered: