Fix mf file loading error #2155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code was incorrectly checking if loop variable `i` was greater than maximum data length, rather than checking current buffer pointer.
|
You are welcome to add an entry to the CHANGELOG.md as well |
|
Nice catches! Something makes me believe that more json loading parts could use your fixes... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code was incorrectly checking the loop variable
i,rather than checking the used data length / current buffer pointer.
This causes dumps with all 64 sectors of data to refuse to load, with false error message that the data buffer size was exceeeded.
Also improved flow for dump files, by providing distinct error message when a data block in the JSON ...
Bonus fix for that third case (< 16 bytes):
The old code would save the partial-block into the buffer ... but all future blocks of data would then be loaded at an incorrect offset. The fixed code ensures zero-filled data is used, and this is noticable at the client via the warning message.