Update cmdhficlass.c #2153
Update cmdhficlass.c #2153
Conversation
Fixed ranges for configcards generation
|
You are welcome to add an entry to the CHANGELOG.md as well |
client/src/cmdhficlass.c
Outdated
| "hf iclass configcard -l --> download config card settings\n" | ||
| "hf iclass configcard -p --> print all config cards\n" | ||
| "hf iclass configcard -l --> download config card settings (requires card helper)\n" | ||
| "hf iclass configcard -p --> print all config cards in the database (doesn't require cardhelper)\n" |
There was a problem hiding this comment.
Can you suggest a rewording to clarify -p will also work without card helper but -l does require it? As that was my intent behind this clarification
There was a problem hiding this comment.
people always think that if they only write more text, then others will read and understand.
I say, be very precise and to the point. Remove the need for "fillers"
In the over description, remove exampl line with "-l" , remove all your fillers.
There was a problem hiding this comment.
But then removing the example line -l will hide a functionality that's still available in the software but people won't know the command for it. Let me try with a different wording.
Updated to use arraylen as suggested by iceman, but to do so without facing other issues /buggy behaviors I had to perform additional code changes.
|
the last item, was suppose to have a optional length. I see that its been hardcoded to 14 and now 13. |
|
It was already hardcoded to 14 before any changes I made from my end. I changed it to 13 as I removed a line, but that’s it. |
|
yeah, its suppose to be dynamic. |
Fixed ranges for configcards generation to prevent users from generating 00s cards when selecting an unavailable option.
Updated description to clarify cardhelper is optional