Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sharing to other apps in inbox entries #1396

Merged
merged 8 commits into from
Oct 19, 2023
Merged

Conversation

pixeldesu
Copy link
Member

  • Provide both text and url to navigator.share because URL apparently is a must for it to work
  • There probably was a race condition with closing the inbox entry and showing the share dialog, closing now waits for the share dialog to be opened
  • Added an omit_url option to SocialHelper::TwitterMethods#prepare_tweet
  • Just to be sure, added catching errors of the share dialog with a no-op

@pixeldesu pixeldesu requested a review from raccube October 18, 2023 18:09
@pixeldesu pixeldesu requested a review from nilsding as a code owner October 18, 2023 18:09
@codecov
Copy link

codecov bot commented Oct 18, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (86f9fe0) 95.21% compared to head (6e8f8bc) 95.21%.

❗ Current head 6e8f8bc differs from pull request most recent head f95e11c. Consider uploading reports for the commit f95e11c to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1396      +/-   ##
==========================================
- Coverage   95.21%   95.21%   -0.01%     
==========================================
  Files         168      168              
  Lines        2632     2631       -1     
==========================================
- Hits         2506     2505       -1     
  Misses        126      126              
Files Coverage Δ
app/controllers/ajax/answer_controller.rb 100.00% <100.00%> (ø)
app/helpers/social_helper/twitter_methods.rb 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pixeldesu pixeldesu force-pushed the bugfix/inbox-sharing branch from 5fc1f10 to f76c4e2 Compare October 18, 2023 19:12
@pixeldesu pixeldesu merged commit 6ff7b08 into main Oct 19, 2023
10 checks passed
@pixeldesu pixeldesu deleted the bugfix/inbox-sharing branch October 19, 2023 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants