Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forge Patch Diff Tool / Test #2

Open
AterAnimAvis opened this issue Aug 24, 2021 · 0 comments
Open

Forge Patch Diff Tool / Test #2

AterAnimAvis opened this issue Aug 24, 2021 · 0 comments
Labels
forge Related to the Forge repository

Comments

@AterAnimAvis
Copy link
Member

AterAnimAvis commented Aug 24, 2021

The move in FG from diff4j to DiffPatch results in many changes from the Generated Patches such as

-@@ -370,6 +370,14 @@
+@@ -369,6 +369,14 @@
+     {
          return this.func_189101_db() ? SoundEvents.field_189110_fE : SoundEvents.field_187882_fq;
      }
- 
++
 +    /* ======================================== FORGE START =====================================*/
 +    /**
 +     * Called when the slime spawns particles on landing, see onUpdate.
 +     * Return true to prevent the spawning of the default particles.
 +     */
 +    protected boolean spawnCustomParticles() { return false; }
 +    /* ======================================== FORGE END   =====================================*/
-+
+ 
      static class AISlimeAttack extends EntityAIBase
          {
-             private final EntitySlime field_179466_a;

A tool/task to diff the output of the application of the patches pre retrogradle and after retrogradle would be helpfull for finding actual changes (like below) and for verification purposes:

+@@ -295,7 +298,7 @@
+                 {
+                     if (((TileEntityDispenser)p_82487_1_.func_150835_j()).func_146019_a(new ItemStack(item)) < 0)
+                     {
+-                        this.field_150840_b.func_82482_a(p_82487_1_, new ItemStack(item));
++                        this.dispenseBehavior.func_82482_a(p_82487_1_, new ItemStack(item));
+                     }
+ 
+                     return p_82487_2_;
@AterAnimAvis AterAnimAvis added the forge Related to the Forge repository label Aug 27, 2021
@TheCurle TheCurle moved this to Help Wanted in Retrogradle 2.2 Release Mar 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
forge Related to the Forge repository
Projects
Status: Help Wanted
Development

No branches or pull requests

1 participant