Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Node 10 support #30

Open
pierceray opened this issue Dec 10, 2018 · 1 comment
Open

Add Node 10 support #30

pierceray opened this issue Dec 10, 2018 · 1 comment
Assignees

Comments

@pierceray
Copy link
Contributor

We need to add support for node 10 (Dubnium).

@jared-stilwell jared-stilwell self-assigned this Dec 11, 2018
@jared-stilwell
Copy link
Contributor

It seems like the timing of the promises in the unit tests shift in subtle ways starting in node 10.5 but it isn't obvious exactly what is causing the unit tests to not complete successfully. It seems like untangling the tests that use node-tap autocompletion and return promise objects to not have a return value and use an explicit t.end() is a starting point to simplifying matters and perhaps eliminating whatever the issue is altogether.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants