Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

importer produces dupes in the CSS when the pantry package is npm linked into the project #7

Open
elyseholladay opened this issue Oct 28, 2016 · 0 comments

Comments

@elyseholladay
Copy link
Collaborator

elyseholladay commented Oct 28, 2016

To reproduce the error:

cd retailmenot
rm -rf node_modules
npm install
grunt fresh
# note that css like button mixin is not duplicated in the built css in www/gui/build/webpack/desktop
npm link ../roux-ingredients
grunt fresh
# note that css like button mixin is duplicated in the built css in www/gui/build/webpack/desktop

@lzilioli: "I suspect that this was caused by the fact that if pantry instanceOf Pantry, we exited early and did not apply the dedupe logic. I switched this to Pantry.isPantry here which I think will resolve it. I'll close this out once I confirm."

Issue still exists for non-entrypoint sass files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant