DateDiff rule

[gvieiragoulart]

Hey guys, I'm new in this project and I want to contribute by doing the DateDiff rule. But I noticed that we don't have any of differentiation rule.

What do you guys think about creating a new Core rule to help these differentiation rules?

[alganet]

Hi @gvieiragoulart!

For a lot of use cases, you can use v::between(), v::greaterThan() and so on with DateTime instances. See the CanCompareValues trait. I know this is not a full diff that can assert values on the intervals, but it goes a long way.

We also have the MinAge and MaxAge rules, which are kind of a date diff validation, but only for the year part. These provide some scalar based diff, not only boolean comparison. They could be better (microsecond or nanosecond resolution).

Maybe none of these fit what you need. If that's the case, let us know! Maybe draft an example of what this new validator would look like, what do you think?

I think there are some good improvements that could be done over this area. If you want to work on it, you have my blessing!

[henriquemoody]

Hi there!

I've started working on that rule, but due to a succession of major life events, I couldn't complete it for version 3.0.

henriquemoody@9e631a8

Is that what you were looking for, @gvieiragoulart? I'd be happy if anyone picks this up.

[gvieiragoulart]

Hey @henriquemoody @alganet !

If I could pick this task I would be really happy to try complete but it seems to me that you have done almost the entire work. What do you see that we have to improve?

[henriquemoody]

@gvieiragoulart, I don't really know what needs to improve. I know the tests are not passing, though. I won't be working on it any time soon, so if you want to pick it up, I'd be very happy with it!

[alganet]

@gvieiragoulart I have some idea of what the next steps should be:

• Finish the DateDiffException which seems to be missing.
• Complete the tests with all kinds of diff examples
• Change the *Age validators to reuse the new DateDiff ones internally. I would also mark them as deprecated to be removed in a future version (WDYT @henriquemoody?)
• Adjust the docs to reflect the changes (i.e. if we deprecate something, mark as deprecated on that validator markdown file).

PHP also has the DateInterval and DatePeriod classes. One of the core goals of Respect\Validation is to provide tools that fit seamlessly with PHP builtins, so it might be a good idea to add support for them. This should probably go as a separate PR though.

Let us know if you have any other questions, if anything doesn't make sense or require more clarification!

[gvieiragoulart]

@alganet

I didn't find any Age validator on the code to reuse :( i think i missed something.

[alganet]

@gvieiragoulart they're here:

https://github.com/Respect/Validation/blob/main/library/Rules/AbstractAge.php
https://github.com/Respect/Validation/blob/main/library/Rules/MinAge.php
https://github.com/Respect/Validation/blob/main/library/Rules/MaxAge.php

[gvieiragoulart]

Hey guys, I believe that I completed the feature.

@alganet I didn't use those validators because the type is specific to the DateInterval types, so I created another validation.

PR here #1463