Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Request: remove screenshotdetector #188

Open
lukeswitz opened this issue May 14, 2020 · 10 comments
Open

Request: remove screenshotdetector #188

lukeswitz opened this issue May 14, 2020 · 10 comments
Labels
hacktoberfest

Comments

@lukeswitz
Copy link
Contributor

lukeswitz commented May 14, 2020 •
edited
Loading

This feature is baked into TestFlight, data collection must be properly handled, retained and able to be provided to the user with a set expiration, etc.
@farktronix farktronix reopened this Sep 27, 2020
@farktronix
Copy link
Member

I think this is still a useful thing to do, and it also lets us get rid of Relisten attempting to access the photo library

@lukeswitz
Copy link
Contributor Author

lukeswitz commented Oct 3, 2020 •
edited
Loading

Awesome, I'll get that out of there.

@lukeswitz lukeswitz mentioned this issue Oct 6, 2020
Closed
@farktronix
Copy link
Member

Reopening. It's fine if you're done with this, but please leave this open so that someone else can handle it.

@farktronix farktronix reopened this Oct 26, 2020
@lukeswitz
Copy link
Contributor Author

I can break it up so no build settings are changed. Do you have CI firing or is the Travis vs. Realm battle waging on?

@farktronix
Copy link
Member

Thanks! I filed this bug on Realm to see if they have any ideas for fixing the Travis issue: realm/realm-swift#6889

@farktronix
Copy link
Member

I just fixed up all of the build and Travis woes and pushed fixes to master. You should be able to pull out your specific changes for this from #199 into a new PR

@lukeswitz
Copy link
Contributor Author

Awesome! Thanks for the trudging and grinding through all that. Travis sure put up a good fight but I'm glad you won.

@lukeswitz lukeswitz reopened this Oct 29, 2020
@lukeswitz
Copy link
Contributor Author

Wait... the .gitignore had Pods/Realm/**/*.a in it????

This project......ohhh this project.

@farktronix
Copy link
Member

This project......ohhh this project.

The realm pod downloads static binaries that are over 50MB, which GitHub warns about if you try to push them, so we chose to ignore them since they can easily be re-downloaded by Cocoapods:

commit 53aa696c932522a5667d7c5e190709fe5d2f2e6a
Author: Alec Gorge <[email protected]>
Date:   Sun Mar 29 11:39:17 2020 -0700

    Ignore massive Realmbinaries

diff --git a/.gitignore b/.gitignore
index d07f8788..9a8fd9ea 100644
--- a/.gitignore
+++ b/.gitignore

We're working on a complex system with lots of moving parts. Bugs are going to happen, and they're generally going to be due to side effects that nobody could have anticipated. Please assume good intent- we're all trying to do our best.

@lukeswitz
Copy link
Contributor Author

The surprise came from choosing one of thirty to exclude. In a typical development work environment we either include them or we don't. This project is different and I see + respect that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove screenshot feedback
2 participants
@farktronix @lukeswitz