Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid/missing credentials does not cause fail state #35

Open
slaughtr opened this issue Jul 6, 2021 · 3 comments
Open

Invalid/missing credentials does not cause fail state #35

slaughtr opened this issue Jul 6, 2021 · 3 comments
Assignees
Labels
help wanted Extra attention is needed

Comments

@slaughtr
Copy link

slaughtr commented Jul 6, 2021

When deploying, if credentials aren't loaded, the action still counts as a pass. Took us by surprise, as the step "passed". After poking around at Cloudfront it became obvious invalidations weren't happening...and when finally looking in the logs of the deploy action it became very apparent that nothing was happening, but we still had our big green check marks.

Unexpected error: (CredentialsError) Missing credentials in config, if using AWS_CONFIG_FILE, set AWS_SDK_LOAD_CONFIG=1, aborting upload for asset-manifest.json
Unexpected error: (CredentialsError) Missing credentials in config, if using AWS_CONFIG_FILE, set AWS_SDK_LOAD_CONFIG=1, aborting upload for index.html
Unexpected error: (CredentialsError) Missing credentials in config, if using AWS_CONFIG_FILE, set AWS_SDK_LOAD_CONFIG=1, aborting upload for manifest.json
Unexpected error: (CredentialsError) Missing credentials in config, if using AWS_CONFIG_FILE, set AWS_SDK_LOAD_CONFIG=1, aborting upload for precache-
@coulonxyz
Copy link

Same issue here. Cloudfront invalidation failed and the workflows kept going:

Upload finished
AccessDenied: User: arn:aws:sts::***:assumed-role/plan/1234567+XXXX-site+98765432#1 is not authorized to perform: cloudfront:CreateInvalidation on resource: arn:aws:cloudfront::***:distribution/*** because no identity-based policy allows the cloudfront:CreateInvalidation action

@ghost
Copy link

ghost commented Sep 21, 2022

Any news on this topic? I think it's a very serious problem.

@TravelPaul
Copy link

this has just caught us out too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

4 participants