Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using AWS SDK for JavaScript (v2) #146

Open
joaohenriquesouza80 opened this issue Mar 2, 2023 · 4 comments
Open

Using AWS SDK for JavaScript (v2) #146

joaohenriquesouza80 opened this issue Mar 2, 2023 · 4 comments

Comments

@joaohenriquesouza80
Copy link

Hi,

Only a warning:
[email protected] using legacy dependencies and the AWS SDK v2, that will be into maintenance mode in 2023.

Great job.
Hugs

@VitorSponhardi
Copy link

VitorSponhardi commented Mar 21, 2023

Also getting this warning:

Please migrate your code to use AWS SDK for JavaScript (v3).
For more information, check the migration guide at https://a.co/7PzMCcy

@coliff coliff mentioned this issue May 23, 2023
@grudelsud
Copy link

follow up from the other issue (and again, many thanks for publishing this!)

from this comment: #144 (comment)

steps to resolve the deprecated dependencies are:

Integrate the import-io/s3-deploy dependency
Upgrade the aws-sdk dependency (with needed changes)

after having a look around, as @coliff mentioned, the source files for https://www.npmjs.com/package/s3-deploy are gone, so I don't see how these can be updated to a newer version.

my best guess is that the package was using the official AWS sdk, here: https://www.npmjs.com/package/@aws-cdk/aws-s3-deployment so if we could get hold of importio's sources, these could be integrated with this package?

or any other simpler ideas?

@coliff coliff pinned this issue Feb 9, 2024
@gfpacheco
Copy link

@grudelsud you can get your hands on the source for s3-deploy simply by installing it and looking at the node_modules/s3-deploy folder, I agree stop using a 5 year old library is the way to go. I don't have the bandwidth to do it right now, but might try again in the future

@grudelsud
Copy link

@gfpacheco it always feels good when I get reminded of a message written a year before that I completely forgot, thanks! 😄

for what is worth, on new projects I ended up using a simple s3 sync that invokes the AWS command line, this one: https://github.com/marketplace/actions/s3-sync
and a script to invalidate the cloudfront distribution

I'm sorry but I'm more of a python guy and couldn't find time to get my head around the node modules

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

4 participants