Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EMA C++: Method setServiceName() in PostMsgDecoder is a non-operation #297

Closed
miczuc opened this issue Nov 29, 2024 · 2 comments
Closed

Comments

@miczuc
Copy link

miczuc commented Nov 29, 2024

Hello,

I noticed the following small deficiency: The class PostMsgDecoder inherits the virtual method
"setServiceName(const char *, UInt32, bool nullTerm = true)" from class Decoder,
where it is predefined with an empty body. However, there exists a use-case of this method in
PostMsg::PostMsg(const PostMsg& other). The result may be, that the copied PostMsg lacks the service name.
Because of issue #296 ("EMA C++: Post message received in provider does not contain service name set in consumer")
I could not check this.

Regards, Michael Zuck

@vlevendel
Copy link
Contributor

@miczuc This does not appear to be a problem in code where #295 and #296 are addressed. Please reopen if you find otherwise.

@miczuc
Copy link
Author

miczuc commented Dec 5, 2024

Hello, I do not understand, why you close this issue. The copy constructor PostMsg::PostMsg(const PostMsg& other) will not copy the service name. But this cannot be verified, because the service name is never set in a received post message on the provider, even if the consumer sets a service name. These are two independent bugs!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants