Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ema C++ : OmmConsumerClient, OmmConsumerErrorClient forbid copy-constructor for no reason #286

Closed
miczuc opened this issue Sep 19, 2024 · 2 comments

Comments

@miczuc
Copy link

miczuc commented Sep 19, 2024

In a consumer application the classes OmmConsumerClient, OmmConsumerErrorClient must be subclassed
in order to handle messages / events through reimplemented virtual callback methods e.g. onRefreshMsg().
However these classes have a disabled copy-constructor and assignment operator, e.g.:

private :
OmmConsumerClient( const OmmConsumerClient& );
OmmConsumerClient& operator=( const OmmConsumerClient& );

This is complete senseless, since the classes do not contain any data members. It forces the application to use non-copyable classes as handler classes, although it is not necessary. This is an unwanted and unnecessary restriction.

@fogol
Copy link
Contributor

fogol commented Sep 20, 2024

@miczuc Thank you for bringing this to our attention. We will investigate the issue to provide the solution.

@vlevendel
Copy link
Contributor

Fixed with version Real-Time-SDK-2.2.3.L1. Please reopen if there are additional concerns.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants