fix: clean up the discriminator mapping in the remove-x-internal decorator #1694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: ec94fa8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Coverage report
Test suite run success811 tests passing in 121 suites. Report generated by 🧪jest coverage report action from ec94fa8 |
tatomyr
changed the title
tatomyr
force-pushed
the
fix/remove-x-internal-discriminator-mapping
branch
from
9afd155
to
20f7448
Compare
tatomyr
force-pushed
the
fix/remove-x-internal-discriminator-mapping
branch
from
d9c04a6
to
b7b20da
Compare
RomanHotsiy
approved these changes
Oct 18, 2024
| if (resolved.node?.[hiddenTag]) { | ||
| if (resolved.node?.[internalFlagProperty]) { | ||
| // First, remove the reference in the discriminator mapping, if it exists: | ||
| if (parent.discriminator?.mapping) { |
There was a problem hiding this comment.
add extra check for typeof object
JLekawa
approved these changes
Oct 18, 2024
tatomyr
force-pushed
the
fix/remove-x-internal-discriminator-mapping
branch
3 times, most recently
from
88384ae
to
f3e9762
Compare
tatomyr
force-pushed
the
fix/remove-x-internal-discriminator-mapping
branch
from
f3e9762
to
ec94fa8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What/Why/How?
Fixed the
remove-x-internaldecorator, which was not removing the reference in the corresponding discriminator mapping while removing the original $ref.Reference
Fixes #1649
Testing
Screenshots (optional)
Check yourself
Security