From 85a60ba7dcc167488eb095465256eb36f917b405 Mon Sep 17 00:00:00 2001 From: Sabrina Bongiovanni Date: Fri, 15 Mar 2024 16:45:03 +0100 Subject: [PATCH 1/6] fix: translated aria-label of menu hamburger icon --- RELEASE.md | 6 ++++++ .../volto/components/theme/Navigation/Navigation.jsx | 6 +++++- 2 files changed, 11 insertions(+), 1 deletion(-) diff --git a/RELEASE.md b/RELEASE.md index ca92a7d17..ed4b094b6 100644 --- a/RELEASE.md +++ b/RELEASE.md @@ -30,6 +30,12 @@ - ... --> +## Versione X.X.X (dd/mm/yyyy) + +### Fix + +- Tradotto il messaggio per Screen Reader del bottone per aprire e chiudere il menu in mobile. + ## Versione 7.25.3 (07/03/2024) ### Migliorie diff --git a/src/customizations/volto/components/theme/Navigation/Navigation.jsx b/src/customizations/volto/components/theme/Navigation/Navigation.jsx index d54a0468d..01a0c0681 100644 --- a/src/customizations/volto/components/theme/Navigation/Navigation.jsx +++ b/src/customizations/volto/components/theme/Navigation/Navigation.jsx @@ -98,7 +98,7 @@ const Navigation = ({ pathname }) => { { setCollapseOpen(!collapseOpen); setFocusTrapActive(!focusTrapActive); @@ -175,6 +175,10 @@ const messages = defineMessages({ id: 'close-menu', defaultMessage: 'Chiudi menu', }, + ToggleMenu: { + id: 'toggle-menu', + defaultMessage: 'Apri o chiudi il menu', + }, }); Navigation.propTypes = { From 9a0d9a1130f8a042cf8dc8aca69726e42c67750e Mon Sep 17 00:00:00 2001 From: Sabrina Bongiovanni Date: Mon, 18 Mar 2024 09:52:09 +0100 Subject: [PATCH 2/6] fix: used collapseOpen variable to change aria-label message --- .../volto/components/theme/Navigation/Navigation.jsx | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/src/customizations/volto/components/theme/Navigation/Navigation.jsx b/src/customizations/volto/components/theme/Navigation/Navigation.jsx index 01a0c0681..cbff00513 100644 --- a/src/customizations/volto/components/theme/Navigation/Navigation.jsx +++ b/src/customizations/volto/components/theme/Navigation/Navigation.jsx @@ -91,6 +91,8 @@ const Navigation = ({ pathname }) => { document.body.removeEventListener('click', blocksClickListener); }, []); + console.log(collapseOpen); + return (
{menu?.length > 0 ? ( @@ -98,7 +100,9 @@ const Navigation = ({ pathname }) => { { setCollapseOpen(!collapseOpen); setFocusTrapActive(!focusTrapActive); @@ -177,7 +181,7 @@ const messages = defineMessages({ }, ToggleMenu: { id: 'toggle-menu', - defaultMessage: 'Apri o chiudi il menu', + defaultMessage: '{action} il menu', }, }); From 23789fec848dff403021268d87f2f403cb54d043 Mon Sep 17 00:00:00 2001 From: Sabrina Bongiovanni Date: Mon, 18 Mar 2024 09:54:27 +0100 Subject: [PATCH 3/6] chore: removed console.log --- .../volto/components/theme/Navigation/Navigation.jsx | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/customizations/volto/components/theme/Navigation/Navigation.jsx b/src/customizations/volto/components/theme/Navigation/Navigation.jsx index cbff00513..365dec9db 100644 --- a/src/customizations/volto/components/theme/Navigation/Navigation.jsx +++ b/src/customizations/volto/components/theme/Navigation/Navigation.jsx @@ -91,8 +91,6 @@ const Navigation = ({ pathname }) => { document.body.removeEventListener('click', blocksClickListener); }, []); - console.log(collapseOpen); - return (
{menu?.length > 0 ? ( From a4fc8531d0d2e86bb5bd8cc471d5be810e2fb2f4 Mon Sep 17 00:00:00 2001 From: Sabrina Bongiovanni Date: Wed, 27 Mar 2024 14:29:37 +0100 Subject: [PATCH 4/6] fix: added translations for toggleMenu --- locales/de/LC_MESSAGES/volto.po | 15 +++++++++++++++ locales/en/LC_MESSAGES/volto.po | 15 +++++++++++++++ locales/es/LC_MESSAGES/volto.po | 15 +++++++++++++++ locales/fr/LC_MESSAGES/volto.po | 15 +++++++++++++++ locales/it/LC_MESSAGES/volto.po | 15 +++++++++++++++ locales/volto.pot | 17 ++++++++++++++++- .../components/theme/Navigation/Navigation.jsx | 16 +++++++++++++--- src/overrideTranslations.jsx | 12 ++++++++++++ 8 files changed, 116 insertions(+), 4 deletions(-) diff --git a/locales/de/LC_MESSAGES/volto.po b/locales/de/LC_MESSAGES/volto.po index 348f3f803..00f274fcd 100644 --- a/locales/de/LC_MESSAGES/volto.po +++ b/locales/de/LC_MESSAGES/volto.po @@ -3592,6 +3592,21 @@ msgstr "" msgid "to" msgstr "" +#: overrideTranslations +# defaultMessage: {action} il menu +msgid "toggle-menu" +msgstr "" + +#: overrideTranslations +# defaultMessage: Chiudi +msgid "toggleMenu_close" +msgstr "" + +#: overrideTranslations +# defaultMessage: Apri +msgid "toggleMenu_open" +msgstr "" + #: components/ItaliaTheme/Header/HeaderSearch/SearchModal #: components/ItaliaTheme/Search/Search #: components/ItaliaTheme/View/Commons/PageHeader/PageHeaderTassonomiaArgomenti diff --git a/locales/en/LC_MESSAGES/volto.po b/locales/en/LC_MESSAGES/volto.po index 4393c3e51..de19da772 100644 --- a/locales/en/LC_MESSAGES/volto.po +++ b/locales/en/LC_MESSAGES/volto.po @@ -3577,6 +3577,21 @@ msgstr "title" msgid "to" msgstr "to" +#: overrideTranslations +# defaultMessage: {action} il menu +msgid "toggle-menu" +msgstr "" + +#: overrideTranslations +# defaultMessage: Chiudi +msgid "toggleMenu_close" +msgstr "" + +#: overrideTranslations +# defaultMessage: Apri +msgid "toggleMenu_open" +msgstr "" + #: components/ItaliaTheme/Header/HeaderSearch/SearchModal #: components/ItaliaTheme/Search/Search #: components/ItaliaTheme/View/Commons/PageHeader/PageHeaderTassonomiaArgomenti diff --git a/locales/es/LC_MESSAGES/volto.po b/locales/es/LC_MESSAGES/volto.po index c85dcf5c2..0bb57ab38 100644 --- a/locales/es/LC_MESSAGES/volto.po +++ b/locales/es/LC_MESSAGES/volto.po @@ -3586,6 +3586,21 @@ msgstr "título" msgid "to" msgstr "a" +#: overrideTranslations +# defaultMessage: {action} il menu +msgid "toggle-menu" +msgstr "" + +#: overrideTranslations +# defaultMessage: Chiudi +msgid "toggleMenu_close" +msgstr "" + +#: overrideTranslations +# defaultMessage: Apri +msgid "toggleMenu_open" +msgstr "" + #: components/ItaliaTheme/Header/HeaderSearch/SearchModal #: components/ItaliaTheme/Search/Search #: components/ItaliaTheme/View/Commons/PageHeader/PageHeaderTassonomiaArgomenti diff --git a/locales/fr/LC_MESSAGES/volto.po b/locales/fr/LC_MESSAGES/volto.po index 1110229d5..abe9835b0 100644 --- a/locales/fr/LC_MESSAGES/volto.po +++ b/locales/fr/LC_MESSAGES/volto.po @@ -3594,6 +3594,21 @@ msgstr "titre" msgid "to" msgstr "au" +#: overrideTranslations +# defaultMessage: {action} il menu +msgid "toggle-menu" +msgstr "" + +#: overrideTranslations +# defaultMessage: Chiudi +msgid "toggleMenu_close" +msgstr "" + +#: overrideTranslations +# defaultMessage: Apri +msgid "toggleMenu_open" +msgstr "" + #: components/ItaliaTheme/Header/HeaderSearch/SearchModal #: components/ItaliaTheme/Search/Search #: components/ItaliaTheme/View/Commons/PageHeader/PageHeaderTassonomiaArgomenti diff --git a/locales/it/LC_MESSAGES/volto.po b/locales/it/LC_MESSAGES/volto.po index fd65c0621..253610f72 100644 --- a/locales/it/LC_MESSAGES/volto.po +++ b/locales/it/LC_MESSAGES/volto.po @@ -3577,6 +3577,21 @@ msgstr "titolo" msgid "to" msgstr "al" +#: overrideTranslations +# defaultMessage: {action} il menu +msgid "toggle-menu" +msgstr "" + +#: overrideTranslations +# defaultMessage: Chiudi +msgid "toggleMenu_close" +msgstr "" + +#: overrideTranslations +# defaultMessage: Apri +msgid "toggleMenu_open" +msgstr "" + #: components/ItaliaTheme/Header/HeaderSearch/SearchModal #: components/ItaliaTheme/Search/Search #: components/ItaliaTheme/View/Commons/PageHeader/PageHeaderTassonomiaArgomenti diff --git a/locales/volto.pot b/locales/volto.pot index 2607c3774..d82a9dff5 100644 --- a/locales/volto.pot +++ b/locales/volto.pot @@ -1,7 +1,7 @@ msgid "" msgstr "" "Project-Id-Version: Plone\n" -"POT-Creation-Date: 2024-02-29T10:45:35.413Z\n" +"POT-Creation-Date: 2024-03-27T13:29:18.025Z\n" "Last-Translator: Plone i18n \n" "Language-Team: Plone i18n \n" "MIME-Version: 1.0\n" @@ -3579,6 +3579,21 @@ msgstr "" msgid "to" msgstr "" +#: overrideTranslations +# defaultMessage: {action} il menu +msgid "toggle-menu" +msgstr "" + +#: overrideTranslations +# defaultMessage: Chiudi +msgid "toggleMenu_close" +msgstr "" + +#: overrideTranslations +# defaultMessage: Apri +msgid "toggleMenu_open" +msgstr "" + #: components/ItaliaTheme/Header/HeaderSearch/SearchModal #: components/ItaliaTheme/Search/Search #: components/ItaliaTheme/View/Commons/PageHeader/PageHeaderTassonomiaArgomenti diff --git a/src/customizations/volto/components/theme/Navigation/Navigation.jsx b/src/customizations/volto/components/theme/Navigation/Navigation.jsx index 365dec9db..50370ae0a 100644 --- a/src/customizations/volto/components/theme/Navigation/Navigation.jsx +++ b/src/customizations/volto/components/theme/Navigation/Navigation.jsx @@ -98,8 +98,10 @@ const Navigation = ({ pathname }) => { { setCollapseOpen(!collapseOpen); @@ -177,10 +179,18 @@ const messages = defineMessages({ id: 'close-menu', defaultMessage: 'Chiudi menu', }, - ToggleMenu: { + toggleMenu: { id: 'toggle-menu', defaultMessage: '{action} il menu', }, + toggleMenu_open: { + id: 'toggleMenu_open', + defaultMessage: 'Apri', + }, + toggleMenu_close: { + id: 'toggleMenu_close', + defaultMessage: 'Chiudi', + }, }); Navigation.propTypes = { diff --git a/src/overrideTranslations.jsx b/src/overrideTranslations.jsx index 3667a5eaf..73616d8a6 100644 --- a/src/overrideTranslations.jsx +++ b/src/overrideTranslations.jsx @@ -25,4 +25,16 @@ const messages = defineMessages({ id: 'rrule_on the', defaultMessage: 'il', }, + toggleMenu: { + id: 'toggle-menu', + defaultMessage: '{action} il menu', + }, + toggleMenu_open: { + id: 'toggleMenu_open', + defaultMessage: 'Apri', + }, + toggleMenu_close: { + id: 'toggleMenu_close', + defaultMessage: 'Chiudi', + }, }); From 07ad73cfd4e8dff58047e83641d588e47e4adc49 Mon Sep 17 00:00:00 2001 From: Sabrina Bongiovanni Date: Wed, 3 Apr 2024 10:13:57 +0200 Subject: [PATCH 5/6] fix: added EN translations --- locales/en/LC_MESSAGES/volto.po | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/locales/en/LC_MESSAGES/volto.po b/locales/en/LC_MESSAGES/volto.po index efb592b06..2a758a19e 100644 --- a/locales/en/LC_MESSAGES/volto.po +++ b/locales/en/LC_MESSAGES/volto.po @@ -3595,17 +3595,17 @@ msgstr "to" #: overrideTranslations # defaultMessage: {action} il menu msgid "toggle-menu" -msgstr "" +msgstr "{action} the menu" #: overrideTranslations # defaultMessage: Chiudi msgid "toggleMenu_close" -msgstr "" +msgstr "Close" #: overrideTranslations # defaultMessage: Apri msgid "toggleMenu_open" -msgstr "" +msgstr "Open" #: components/ItaliaTheme/Header/HeaderSearch/SearchModal #: components/ItaliaTheme/Search/Search From c267ead79b35ff45381c41e3b9f0b614dadb7476 Mon Sep 17 00:00:00 2001 From: Sabrina Bongiovanni Date: Wed, 3 Apr 2024 10:23:02 +0200 Subject: [PATCH 6/6] chore: changed release.md --- RELEASE.md | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/RELEASE.md b/RELEASE.md index b7ed84293..11602e7ca 100644 --- a/RELEASE.md +++ b/RELEASE.md @@ -32,9 +32,6 @@ ## Versione X.X.X (dd/mm/yyyy) -### Fix - -- Tradotto il messaggio per Screen Reader del bottone per aprire e chiudere il menu in mobile. ### Novità - Aggiunto nuovo filtro per Data di chiusura del procedimento nel blocco di ricerca Bandi @@ -51,6 +48,7 @@ - Sistemato al cambio pagina il reset dei risultati di ricerca nei blocchi di ricerca Bandi, Eventi e UO - Sistemato layout del menu laterale sinistro nella vista del Bando - Sistemato il flag Mostra tipologia bandi nel blocco elenco con variazione Bandi in Evidenza +- Tradotto il messaggio per Screen Reader del bottone per aprire e chiudere il menu in mobile. ## Versione 7.25.3 (07/03/2024)