Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add 3rd party yara rules integration #4253

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

michalslomczynski
Copy link
Contributor

All Pull Requests:

Check all that apply:

  • Have you followed the guidelines in our Contributing document, including the instructions about commit messages?
  • No Sensitive Data in this change?
  • Is this PR to correct an issue?
  • Is this PR an enhancement?

Complete Description of Additions/Changes:

Add your description here

@michalslomczynski michalslomczynski force-pushed the 3rd_party_rules branch 2 times, most recently from 173223f to 9e2398b Compare October 16, 2024 18:50
@codecov-commenter
Copy link

codecov-commenter commented Oct 16, 2024

Codecov Report

Attention: Patch coverage is 83.52941% with 14 lines in your changes missing coverage. Please review.

Project coverage is 77.02%. Comparing base (3cbf494) to head (9e2398b).

Files with missing lines Patch % Lines
...ts/specs/datasources/malware_detection/__init__.py 83.52% 9 Missing and 5 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4253      +/-   ##
==========================================
+ Coverage   77.00%   77.02%   +0.01%     
==========================================
  Files         761      761              
  Lines       41464    41485      +21     
  Branches     8763     8763              
==========================================
+ Hits        31930    31952      +22     
+ Misses       8481     8480       -1     
  Partials     1053     1053              
Flag Coverage Δ
unittests 77.00% <83.52%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xiangce xiangce added the app Apps embedded in the Insights Core label Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app Apps embedded in the Insights Core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants