Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] rgb values, overlay tokens #126

Open
zeroedin opened this issue Dec 18, 2023 · 3 comments
Open

[bug] rgb values, overlay tokens #126

zeroedin opened this issue Dec 18, 2023 · 3 comments

Comments

@zeroedin
Copy link
Contributor

In rh-table we are using transparencies with various crayon tokens. Even though we try and avoid using crayons in components, we are using them there because they provide RGB values to which we can apply opacity.

We are also using #FFFFFF or --rh-color-white which does not provide RGB values. I have created a --_rh-color-white-rgb private var as a place holder for now.

Should we though ensure all base crayon colors have RGB values?

Do we think we should abstract these RGB values into overlay tokens which provide could provide additional semantic layer so they would be used in a component instead of the crayon? I envision some difficulty in abstracting the color values + opacity level in doing so to the name of the tokens.

@bennypowers
Copy link
Member

bennypowers commented Dec 18, 2023

Would oklch (why?) be of interest to our studio designers? This could be an interesting avenue to pursue in the new year.

@zeroedin
Copy link
Contributor Author

This could be an interesting avenue to pursue in the new year.

I like this, could be a good solution.

@marionnegp
Copy link
Contributor

Would oklch (why?) be of interest to our studio designers?

Would this replace our -rgb and -hsl tokens? Not sure how helpful oklch would be until it can be used within our design tools.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants