Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App authentication key #13

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

professorbinocs
Copy link
Contributor

Provides an option to enter an authentication key.

Description

Changes to manager for an authentication key.
Sends the authentication key when requested from the app.
Credit for the handleConfigRequest function goes to the app's maintainer.

Motivation and Context

Necessary if an app needs to request an authentication key.

How Has This Been Tested?

Tested thoroughly across all instances.
Tested from fresh clone through to scanning.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@cloud9team
Copy link

This looks good. It would be nice if the app key was requested after backend url, so it wouldn't require manual input for every device. Also, sidenote: if a pr goes through for uic source files it would be an excellent opportunity to better organize the device settings order. The settings as they are laid out now have no flow because each option keeps getting added to the bottom. (Completely unrelated to current pr submitted, just for clarification)

@professorbinocs
Copy link
Contributor Author

I completely agree on placement, I placed it at the bottom solely to follow previous PR's that added to config options.
For readers convenience:
A temporary workaround for existing installations is to copy over your previous sqlite db and edit it directly and apply the key there. (DB Browser for SQLite is a nice MacOS option)
ALTER TABLE device ADD COLUMN appKey DEFAULT "YourKeyHere";
For new installations, changing the defaults in the manager to add the app key before adding devices would be ideal.

@JoniValles
Copy link

I tested it on 4 iPhone SEs, its working fine so far.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants