Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect behavior of kinetic entries #212

Open
xiaoruiDong opened this issue Feb 18, 2021 · 1 comment
Open

Incorrect behavior of kinetic entries #212

xiaoruiDong opened this issue Feb 18, 2021 · 1 comment

Comments

@xiaoruiDong
Copy link
Contributor

Bug Description

Kinetics search on the RMG website can't calculate the reactions rates for some mechanisms, which look like this one:
image
While their reverse reactions rates can be found:
image

How to Reproduce

1 N u0 p1 c0 {2,S} {3,S} {4,S}
2 H u0 p0 c0 {1,S}
3 H u0 p0 c0 {1,S}
4 X u0 p0 c0 {1,S}

react with

1 N u0 p1 c0 {2,S} {3,S} {4,S}
2 H u0 p0 c0 {1,S}
3 H u0 p0 c0 {1,S}
4 X u0 p0 c0 {1,S}

Expected Behavior

RMG can calculate the rates of these reactions

Installation Information

  • RMG-website

Additional Context

other examples:

  • N2H4_X ⇔ N2H4 + X , in Surface_Adsorption_vdW
  • H2_X ⇔ H2 + X , in Surface_Adsorption_vdW
  • H_X + NH2_X ⇔ NH3 + X + X , in Surface_Adsorption_Dissociative
  • N2H_X ⇔ H_X + N2 , in Surface_EleyRideal_Addition_Multiple_Bond
  • X_O2_X ⇔ O2 + X + X , in Surface_Adsorption_Bidentate
  • N_X + N_X ⇔ N2 + X + X , in Nitrogen

Originally posted by @Tingchenlee in ReactionMechanismGenerator/RMG-Py#2079

@xiaoruiDong xiaoruiDong changed the title ### Bug Description Incorrect behavior of kinetic entries Feb 18, 2021
@xiaoruiDong xiaoruiDong self-assigned this Feb 18, 2021
@xiaoruiDong
Copy link
Contributor Author

@Tingchenlee Hi Ting-Chen, thank you for reporting this issue. The example you showed (and also other examples you mentioned) is a reaction whose kinetics is defined from the reverse direction. That is the reason why you can get the reverse rate coefficient with no problem. In RMG-website's implementation, generate_reverse_rate_coefficient (a method of Reaction) is called to get the forward rate of those reactions. However, many kinetics model defined in the surface.pyx (e.g., StickingCoefficientBEP) don't support this method. Therefore, in order to get those forward rates and visualize them on RMG-website, you need to modify the generate_reverse_rate_coefficient function first. Please let me know after you or someone in your group makes such modifications, and I can help you with further testing. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant