Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Universal Database for both RMG-Py and RMG-Java #29

Closed
rwest opened this issue Feb 7, 2014 · 1 comment
Closed

Universal Database for both RMG-Py and RMG-Java #29

rwest opened this issue Feb 7, 2014 · 1 comment

Comments

@rwest
Copy link
Member

rwest commented Feb 7, 2014

We just discussed (again) forming a universal database structure for both RMG-Py and RMG-Java. Here are my notes from the videoconference. Add discussion and development notes below...

Universal Database

  • human editable and readable
    • look more like a spreadsheet - eg. one line per reaction.
    • minimize boilerplate
    • excel sheets? csv?
    • benefit of plan text
      • editable using emacs over ssh
      • works with git
  • should store
    • dictionary in new 4-column adjacency list with explicit hydrogens
    • comments
    • uncertainties
    • confidences
    • libraries
    • rules
    • groups
    • depositories (actual reactions, with labeled atoms)
  • exportable to Java
    • remove N and fourth column
    • or modify Java so it can parse the universal database
  • exportable to Python
    • use "import to database" script,
    • or make it read the universal database
    • modify the .load() methods
  • Instead of exporting, Make both read the universal database
    • Java could ignore the extra column in the adjacency list, and all N atom types
    • Benefit: people won't be tempted to edit the exported database!
    • Should be designed so new features are backwards compatible,
      • perhaps programs ignore stuff they don't understand
      • eg. temperature-dependent viscosity parameters in solvent database.
      • transition state estimate databases
      • new atom types
    • Possible drawback
      • risk slowing development of new features (barrier: have to implement in both)
      • or keep breaking RMG-Java
@connie
Copy link
Member

connie commented Jul 27, 2016

Java is dead.

@connie connie closed this as completed Jul 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants