Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disproportionation tree badly formed? #158

Closed
mliu49 opened this issue Jan 17, 2017 · 2 comments
Closed

Disproportionation tree badly formed? #158

mliu49 opened this issue Jan 17, 2017 · 2 comments

Comments

@mliu49
Copy link
Contributor

mliu49 commented Jan 17, 2017

One of the head nodes in the disproporationation family is Y_rad_birad_trirad_quadrad, defined as a logic node, OR{Y_1centerquadrad, Y_1centertrirad, Y_2centerbirad, Y_1centerbirad, Y_rad, H_rad}.

Y_rad is defined as R u1, and H_rad is defined as H u1, so they are not mutually exclusive. This leads to any disprop reaction involving an H radical having twice the expected degeneracy.

I wanted to ask and confirm that this is not intentional, and that Y_rad should be changed to be R!H u1.

@nyee
Copy link
Contributor

nyee commented Jan 17, 2017

In the tree H_rad is L3 level with parent as Y_rad. I think its a mistake in the definition of Y_rad_birad_trirad_quadrad: it should not have H_rad. Could be a mistake from sloppy (probably my) tree-reordering.

Either way as a very small amount of optimization, I would recommend moving H_rad higher in the tree because it is probably the most commonly hit radical.

@mliu49
Copy link
Contributor Author

mliu49 commented Jan 17, 2017

Ah, good point. I didn't look at the tree. I'll make a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants